Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed CI builds by updating their configuration #367

Merged
merged 37 commits into from
Sep 15, 2024

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Aug 14, 2024

Hello!

This PR update the current CI in order to some builds that are failing due Github Actions update.

More information about available images: https://github.com/actions/runner-images/tree/main?tab=readme-ov-file#available-images

  • Linux

    • Using only compiler pre-installed in the official Github Ubuntu images.
    • Installed Ninja to build faster
    • Updated to use newer versions of GCC and Clang
  • Windows

    • Using Ninja to build faster
    • Skipped few tests for Clang in Windows 2022 due segfault. There is a FIXME
  • MacOS

    • Using Ninja to build faster
    • Reduced the number of Clang used as it consumed more time to start then others
    • Using newer compiler versions
  • Android

    • Removed bojoe/cpp-android-ndk-build-env-ubuntu as it's abandoned. Last update was 4 years ago
    • Using pre-installed NDK available in the official Github Action Ubuntu 24.04 (r27)
    • Installed Ninja to build faster

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

Closing this PR for now to avoid wasting the CI. I'll run all tests in my fork instead.

So far, Linux and MacOS are fixed. Still need to fix Windows and Android builds.

After fixing these two scenarios, I'll re-open the PR. See you soon!

@uilianries uilianries closed this Aug 15, 2024
@uilianries uilianries changed the title Update Ubuntu versions on CI Fix failed CI builds by updating their configuration Aug 15, 2024
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries reopened this Aug 15, 2024
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries marked this pull request as ready for review August 15, 2024 10:02
@uilianries
Copy link
Member Author

@ColinH Could you please review this one. Meanwhile, I'll check the msys build for CI.

@uilianries uilianries mentioned this pull request Sep 14, 2024
@ColinH
Copy link
Member

ColinH commented Sep 14, 2024

If it works I'm happy ;-)

@uilianries uilianries merged commit 3bf9d44 into taocpp:main Sep 15, 2024
60 checks passed
@uilianries uilianries deleted the infra/update-ci-images branch September 15, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants