Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump all packages versions #502

Merged
merged 8 commits into from
Feb 1, 2024
Merged

bump all packages versions #502

merged 8 commits into from
Feb 1, 2024

Conversation

panekj
Copy link
Collaborator

@panekj panekj commented Nov 2, 2023

close #386
close #403
close #473
close #480

@panekj
Copy link
Collaborator Author

panekj commented Nov 14, 2023

(didn't forget about this, just crunching at work so hard to keep things afloat you wouldn't believe)

This was linked to issues Nov 28, 2023
@JounQin
Copy link
Collaborator

JounQin commented Dec 14, 2023

@panekj So this PR still doesn't receive updates after #403 (comment).

@panekj
Copy link
Collaborator Author

panekj commented Dec 14, 2023

@panekj So this PR still doesn't receive updates after #403 (comment).

Comments in issues actually don't decrease work I have so no, there has been no update.

@panekj
Copy link
Collaborator Author

panekj commented Dec 14, 2023

What is mainly missing is changelog to collect and write up.

@JounQin
Copy link
Collaborator

JounQin commented Dec 14, 2023

What is mainly missing is changelog to collect and write up.

@panekj They should be definitely managed by tools like changesets FYI, manually maintaining such verbose jobs is boring and tiring IMO.

@flying-sheep
Copy link
Contributor

I personally like https://release-plz.ieni.dev/

It works like this:

  1. create a changelog file in the supported format
  2. add a workflow that runs the GitHub action
  3. whenever you make commits, the action creates or updates a PR with the changelog
  4. when you merge the PR, a new release is tagged and uploaded to crates.io

@JounQin
Copy link
Collaborator

JounQin commented Jan 12, 2024

@flying-sheep Where are the changelog contents from?

@flying-sheep
Copy link
Contributor

there’s 3 paragraphs on the linked website, the second of which answers your question better than I can.

@JounQin
Copy link
Collaborator

JounQin commented Jan 12, 2024

Release-plz updates your changelogs with git-cliff using Keep a changelog format by default.

OK, it's still commit message based, what means the changelog can not be changed after committed. Not flexible as changesets.

@flying-sheep
Copy link
Contributor

flying-sheep commented Jan 12, 2024

Whatever works best for you!

Just FYI: with release-plz, you can change the changelog in the PR before merging. The changelog/versions it autogenerates are not just message based, it also analyzes your code and figures out if your API changes classify as breaking or not.

But in the end, you are in control. Check out this example for a release PR: release-plz/release-plz#1170

PS: I’m just trying to help! I’d love a new Taplo release soon.

@JounQin JounQin marked this pull request as ready for review January 28, 2024 13:37
@JounQin
Copy link
Collaborator

JounQin commented Jan 28, 2024

# taplo/js/cli
yarn build
warning: unused import: `taplo_common::environment::Environment`
   --> src/lib.rs:216:9
    |
216 |     use taplo_common::environment::Environment;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

warning: `taplo-wasm` (lib) generated 1 warning (run `cargo fix --lib -p taplo-wasm` to apply 1 suggestion)
    Finished dev [unoptimized] target(s) in 1.48s
Downloading wasm-bindgen version 0.2.82
[!] (plugin rpt2) Error: Could not load /Users/JounQin/Workspaces/GitHub/taplo/crates/taplo-wasm/Cargo.toml (imported by src/cli.ts): Rust compilation failed

It seems that I'm blocked by @wasm-tool/rollup-plugin-rust, does anyone has any idea?

cc @tamasfe @ia0 @panekj

Maybe we should migrate to https://github.com/napi-rs/napi-rs ASAP.

Resolved by upgrading wasm-bindgen crate.

@tamasfe @ia0 @panekj

Please help to review, so we can release the new versions.

@JounQin JounQin requested review from tamasfe and ia0 January 28, 2024 14:25
@JounQin JounQin self-assigned this Jan 28, 2024
@JounQin
Copy link
Collaborator

JounQin commented Jan 28, 2024

@tamasfe

Can we change the merge option from merge to squash or rebase (disable adding a new merge commit option)?

image

@JounQin
Copy link
Collaborator

JounQin commented Jan 31, 2024

I'll merge this PR as-is soon later.

@tamasfe
Copy link
Owner

tamasfe commented Jan 31, 2024

@tamasfe

Can we change the merge option from merge to squash or rebase (disable adding a new merge commit option)?
image

Sure, squashing by default is a bad idea, but I prefer rebasing as well.

@JounQin
Copy link
Collaborator

JounQin commented Jan 31, 2024

@tamasfe Merging with a new commit can be disabled in GitHub settings.

@JounQin JounQin merged commit 4bf7b53 into master Feb 1, 2024
4 checks passed
@JounQin JounQin deleted the new-release branch February 1, 2024 02:22
@JounQin
Copy link
Collaborator

JounQin commented Feb 1, 2024

@tamasfe

https://crates.io/crates/taplo-cli

It seems the crates were not released correctly, can you help to release manually or give me the release permission so I can do it even after?

https://www.npmjs.com/package/@taplo/cli (v0.7.0 expected)

Same as js npm packages.

I'm JounQin on crates.io, and jounqin on npmjs.com.

@tamasfe
Copy link
Owner

tamasfe commented Feb 1, 2024

Weird, the tags seem to be correct to me yet no CI started. I've sent invites both on crates and npm.

I'll figure out how to grant permission to the vscode extension at microsoft and openvsx later.

@JounQin JounQin changed the title bump versions bump all packages versions Feb 1, 2024
@JounQin
Copy link
Collaborator

JounQin commented Feb 1, 2024

@tamasfe Thanks for your trust, I've published all crates and npm packages successfully except https://crates.io/crates/lsp-async-stub, although it is not in emergency situation.

I'll keep working on better release workflow on #537 and #538.

@JounQin
Copy link
Collaborator

JounQin commented Feb 2, 2024

@tamasfe Would you mind to add me as owner for https://crates.io/crates/lsp-async-stub at the same time when you're free? So that I can help to publish a new version for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants