You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
None of these explicitly named arguments can be used as arguments to the contextual data added to a log message. That's fair enough, and we prefixed them with _ because the likelyhood of a user wishing to have a log message with "_prefix": "some value" in the structured data was very low.
However, "name" is a pretty easy want for callers. If I'm a user it's likely that I'm going to run into a situation where I want "name" to be in the contextual data:
Notice the current
__init__
signature for aLoggingContext
:None of these explicitly named arguments can be used as arguments to the contextual data added to a log message. That's fair enough, and we prefixed them with
_
because the likelyhood of a user wishing to have a log message with"_prefix": "some value"
in the structured data was very low.However,
"name"
is a pretty easy want for callers. If I'm a user it's likely that I'm going to run into a situation where I want"name"
to be in the contextual data:^ It's reasonable to want this.
To address this, we should change the
__init__
signature:Just make
name
_name
like we're doing for_prefix
.The text was updated successfully, but these errors were encountered: