Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaleComputeY may return an array, when integer is required #29

Open
szymach opened this issue Mar 8, 2017 · 3 comments
Open

scaleComputeY may return an array, when integer is required #29

szymach opened this issue Mar 8, 2017 · 3 comments
Labels

Comments

@szymach
Copy link
Owner

szymach commented Mar 8, 2017

There are multiple places when the result of scaleComputeY is used as parameters of function, that expect integers. This may yield unexpected results or errors.

@szymach szymach added the bug label Mar 8, 2017
@szymach szymach changed the title scaleComputeY may result array, when integer is required scaleComputeY may return an array, when integer is required Mar 8, 2017
@bozhinov
Copy link

in my branch I solved it by separating the functions for single input and for array
in that way I was able to verify both input and output

@szymach
Copy link
Owner Author

szymach commented Dec 27, 2017

So you would change the interface of classes. This would require me to start a new version, 4.x, that would not provide 100% BC, but I think it can do that leap. Let us push as many of your non-BC breaking fixes to the current master branch, then I will make a 3.x branch out of it and we can start doing things that will break BC.

@bozhinov
Copy link

scaleComputeY is an internal function. changing it would not break compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants