Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing requested update for Email / Phone based on Location Type not providing the proper action #52

Open
shaneonabike opened this issue Jul 18, 2024 · 0 comments

Comments

@shaneonabike
Copy link

While testing a few submissions, I noticed that on the Processing requested updates page were not choosing the proper action when there already existed a matching record.

How to reproduce

  1. Create a Contact that has an Email with a Location Type of Work
  2. Create a new Activity for this extension that has a new Email and matching Location Type Work as above
  3. Go to the Processing requested update page
  4. See that the Email Data is displaying the Add new Phone action rather than the Overwrite existing action
  5. Repeat above but with Phone

What was expected

It would appropriate choose the proper action based on seeing a duplicate Location Type based on that field.

Solution

I found what appears to be a mistype (?) in the code. Basically, the action code is checking for a field that doesn't exist, but does exist in the processed code. When I changed that it was working great.

I'll post a merge request shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant