Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBB instead of OpenMP #7

Open
alecjacobson opened this issue Apr 5, 2021 · 2 comments
Open

TBB instead of OpenMP #7

alecjacobson opened this issue Apr 5, 2021 · 2 comments

Comments

@alecjacobson
Copy link
Collaborator

I'd like to integrate nasoq into a larger piece of code that is using TBB for multithreading. I'm thinking of forking nasoq and replacing all openmp parallelism with TBB.

I'm nervous to stray to far from the official nasoq branch. The easiest solution would be if the official branch would consider merging this OpenMP with TBB replacement. Is there a special reason to use OpenMP instead of TBB?

Alternatively, it might be possible to abstract the code to take either openmp or tbb (e.g., via compiler flags).

@cheshmi
Copy link
Collaborator

cheshmi commented Apr 14, 2021

I removed OpenMP dependency for now by defining a new definition OPENMP. It is on branch https://github.com/sympiler/nasoq/tree/openmp_rem . I will merge it after I tested thoroughly.
No, there is no specific reason that I do not use TBB in NASOQ. Adding it as an option should be useful.

@cheshmi
Copy link
Collaborator

cheshmi commented Apr 17, 2021

Merged with the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants