Skip to content

Commit

Permalink
feature #58335 [Notifier] deprecate the TransportFactoryTestCase (xab…
Browse files Browse the repository at this point in the history
…buh)

This PR was merged into the 7.2 branch.

Discussion
----------

[Notifier] deprecate the TransportFactoryTestCase

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Issues        | Fix #54100
| License       | MIT

Commits
-------

c8b0fcc77b deprecate the TransportFactoryTestCase
  • Loading branch information
fabpot committed Sep 27, 2024
2 parents a30dbf0 + ecc4a36 commit a8c8848
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
15 changes: 13 additions & 2 deletions Tests/FreeMobileTransportFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,15 @@
namespace Symfony\Component\Notifier\Bridge\FreeMobile\Tests;

use Symfony\Component\Notifier\Bridge\FreeMobile\FreeMobileTransportFactory;
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;

final class FreeMobileTransportFactoryTest extends TransportFactoryTestCase
final class FreeMobileTransportFactoryTest extends AbstractTransportFactoryTestCase
{
use IncompleteDsnTestTrait;
use MissingRequiredOptionTestTrait;

public function createFactory(): FreeMobileTransportFactory
{
return new FreeMobileTransportFactory();
Expand Down Expand Up @@ -45,4 +50,10 @@ public static function unsupportedSchemeProvider(): iterable
yield ['somethingElse://login:pass@default?phone=0611223344'];
yield ['somethingElse://login:pass@default']; // missing "phone" option
}

public static function incompleteDsnProvider(): iterable
{
yield ['freemobile://login@default?phone=0611223344'];
yield ['freemobile://:pass@default?phone=0611223344'];
}
}
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"require": {
"php": ">=8.2",
"symfony/http-client": "^6.4|^7.0",
"symfony/notifier": "^6.4|^7.0"
"symfony/notifier": "^7.2"
},
"autoload": {
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\FreeMobile\\": "" },
Expand Down

0 comments on commit a8c8848

Please sign in to comment.