Bind PN BinaryTrajectories in Python #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
reviewed
Nov 7, 2024
Comment on lines
32
to
35
| .def( | ||
| "positions", | ||
| [](const BinaryTrajectories& binary_trajectories, | ||
| const py::array_t<double> time) -> py::array_t<double> { |
There was a problem hiding this comment.
If you're already going to be doing this in C++, why not just add it to the BinaryTrajectories class.
nilsvu
force-pushed
the
py_binary_traj
branch
from
e1516db
to
0a5695a
Compare
knelli2
requested changes
Nov 8, 2024
nilsvu
force-pushed
the
py_binary_traj
branch
from
0a5695a
to
0eea3c1
Compare
|
@knelli2 fixed |
knelli2
approved these changes
Nov 11, 2024
|
Ignoring unrelated test timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Useful to test pipeline code like ecc-control.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments