Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support clang 19 & CMake 3.30, allow to toggle executable size optimization on Apple Silicon #6356

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Support clang 19 & CMake 3.30, allow to toggle executable size optimization on Apple Silicon #6356

merged 3 commits into from
Nov 7, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Oct 30, 2024

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu changed the title Support clang 19, allow to toggle executable size optimization on Apple Silicon Support clang 19 & CMake 3.30, allow to toggle executable size optimization on Apple Silicon Oct 30, 2024
kidder
kidder requested changes Nov 4, 2024
View reviewed changes
src/NumericalAlgorithms/LinearSolver/ExplicitInverse.hpp
@@ -54,7 +54,6 @@ struct ExplicitInverse {
* cost, but all successive solves converge immediately.
*
* \par Advice on using this linear solver:
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change should be in the previous commit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@nilsvu
Copy link
Member Author

nilsvu commented Nov 6, 2024

@kidder could you merge this so I can build develop on my machine again?

@kidder kidder merged commit f387ab8 into sxs-collaboration:develop Nov 7, 2024
22 of 23 checks passed
@nilsvu nilsvu deleted the clang-19 branch November 7, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidder kidder kidder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsvu @kidder