Add UpdateFunctionsOfTime action
#6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikwit
force-pushed
the
update-functions-of-time
branch
from
f3734d5
to
96993d9
Compare
knelli2
requested changes
Nov 7, 2024
tests/Unit/Helpers/Evolution/Systems/CurvedScalarWave/Worldtube/TestHelpers.cpp
Show resolved
Hide resolved
...Evolution/Systems/CurvedScalarWave/Worldtube/SingletonActions/InitializeEvolvedVariables.hpp
Outdated
Show resolved
Hide resolved
src/Evolution/Systems/CurvedScalarWave/Worldtube/SingletonActions/UpdateFunctionsOfTime.hpp
Show resolved
Hide resolved
src/Evolution/Systems/CurvedScalarWave/Worldtube/SingletonActions/UpdateFunctionsOfTime.hpp
Outdated
Show resolved
Hide resolved
...Evolution/Systems/CurvedScalarWave/Worldtube/SingletonActions/Test_UpdateFunctionsOfTime.cpp
Outdated
Show resolved
Hide resolved
knelli2
reviewed
Nov 12, 2024
nikwit
force-pushed
the
update-functions-of-time
branch
from
e59beb2
to
4ecdf1d
Compare
|
My bad, I accidentally left out some of the changes. I pushed a new fixup. |
nikwit
force-pushed
the
update-functions-of-time
branch
from
4ecdf1d
to
740bd18
Compare
|
done, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the action that adjusts the functions of time according to the motion of the particle.
depends on #6255 #6261