Support complex numbers in DG routines #6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
complex_numbers
branch
5 times, most recently
from
b26e191
to
9cf3b04
Compare
nilsvu
force-pushed
the
complex_numbers
branch
4 times, most recently
from
03380f4
to
48eb48b
Compare
|
@wthrowe would you be able to take this one? |
|
I also have a full integration test using the elliptic DG operator on a complex equation. I was going to add that in the next PR, but could push it here too if you prefer. |
wthrowe
requested changes
Aug 30, 2024
| void test_with_random_values( | ||
| const DataVector& used_for_size, | ||
| Tensor<DataVector, Symm, | ||
| Tensor<DataType, Symm, |
There was a problem hiding this comment.
Call the test function with the new type.
|
I think you messed up rebasing or something. You added a bunch of new commits that don't seem to compile. |
nilsvu
force-pushed
the
complex_numbers
branch
from
8fd1f90
to
243e018
Compare
|
Oh sorry here's the fixup |
|
Looks good. Squash. |
Used in error messages.
nilsvu
force-pushed
the
complex_numbers
branch
from
243e018
to
bf87d6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This completes the support for complex numbers in the DG code.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments