Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NeighborPackagedData into cpp files & allow volume tags in dg boundary terms #5888

Conversation

nilsdeppe
Copy link
Member

Proposed changes

  • Some simplifications and moving code to cpp files. This is most of the line changes.
  • Allow getting volume tags in dg_boundary_terms functions. This is necessary for fancier Riemann solvers like GFORCE that require a primitive recovery in the boundary terms computation.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe requested a review from kidder March 26, 2024 22:47
@nilsdeppe nilsdeppe merged commit b5f4979 into sxs-collaboration:develop Mar 28, 2024
21 of 22 checks passed
@nilsdeppe nilsdeppe deleted the apply_boundary_corrections_updates branch March 28, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants