Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spins to BBH ID input file #5868

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Mar 19, 2024

Proposed changes

Set horizon rotation parameters to a good guess based on the specified dimensionless spins, using Eq. (8) of https://arxiv.org/abs/1506.01689. Later we'll add outer iterations to control the rotation parameters within the executable.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu force-pushed the fix_id_spin branch 2 times, most recently from 6a0a620 to 87bf8f5 Compare March 19, 2024 06:38
@nilsdeppe nilsdeppe merged commit 31d1106 into sxs-collaboration:develop Mar 27, 2024
22 checks passed
@nilsvu nilsvu deleted the fix_id_spin branch April 17, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants