Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev containers for all of our images #5853

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Mar 15, 2024

Proposed changes

Makes opening the repo in the different containers significantly easier than having to edit a single dev container file every time.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 requested a review from nilsvu March 15, 2024 07:59
@knelli2
Copy link
Contributor Author

knelli2 commented Apr 15, 2024

@nilsvu What do you think of these changes? I think they will be useful for SXS-con and also in general for people who want to use different containers to try things.

@nilsvu
Copy link
Member

nilsvu commented Apr 15, 2024

Yea seems useful, I'm only worried about maintaining all these files. I see some merge logic noted in the docs https://containers.dev/implementors/spec/, so is it possible to have the different files inherit most fields from a parent file?

@knelli2
Copy link
Contributor Author

knelli2 commented Apr 15, 2024

From a quick glance it looks like several fields we use are missing merge logic so we'd still have to copy a decent amount. Not sure if it's worth it to rely on merge logic.

@knelli2
Copy link
Contributor Author

knelli2 commented Aug 21, 2024

@knelli2 and @nilsvu will discuss more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants