Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap RotatingStar to be usable in GhValenciaDivClean #5790

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ncorsobh
Copy link
Contributor

Proposed changes

Adds the RelativisticEuler solution for RotatingStar to the list of WrappedGR solutions usable in GhValenciaDivClean. Adds time derivatives to the solution (all of which identically 0) to allow it to be compatible with this function.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! You can squash and rebase immediately

@ncorsobh ncorsobh force-pushed the quaddev branch 2 times, most recently from 770ba85 to b278dec Compare February 27, 2024 02:39
@nilsdeppe
Copy link
Member

CI failure is unrelated to this PR

@nilsdeppe nilsdeppe merged commit bd1bdf3 into sxs-collaboration:develop Feb 29, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants