Prevent NumGridPointsAndGridSpacing element dist when using GTS #5769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
force-pushed
the
element_dist_restriction
branch
2 times, most recently
from
3be6f42
to
891e318
Compare
wthrowe
requested changes
Feb 15, 2024
src/Domain/ElementDistribution.hpp
Outdated
|
|
||
| template <typename Metavariables> | ||
| static constexpr bool uses_lts_v = | ||
| uses_lts<Metavariables, has_local_time_stepping_v<Metavariables>>::value; |
There was a problem hiding this comment.
This is CREATE_GET_STATIC_MEMBER_VARIABLE_OR_DEFAULT.
src/Domain/ElementDistribution.hpp
Outdated
| if constexpr (not element_weight_detail::uses_lts_v<Metavariables>) { | ||
| PARSE_ERROR( | ||
| options.context(), | ||
| "When using global time stepping, you cannot use " |
There was a problem hiding this comment.
"using GTS" -> "not using LTS" to include elliptic.
Comment on lines
43
to
46
| /// \note When using global time stepping (GTS), a user cannot choose the | ||
| /// NumGridPointsAndGridSpacing element distribution because grid spacing does | ||
| /// not affect the computational cost at all. Therefore, if a user does choose | ||
| /// NumGridPointsAndGridSpacing when using GTS, an error will occur. |
knelli2
force-pushed
the
element_dist_restriction
branch
from
891e318
to
66b4ccb
Compare
|
I squashed directly |
wthrowe
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Also prevent using NumGridPointsAndGridSpacing in the elliptic code as well.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments