Support older control system output in size plotting #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
requested changes
Feb 15, 2024
|
Hmm seems like this needs to be made testable, since there was actually a bug here. |
|
I agree it should be tested, but it's very non-trivial to test. |
knelli2
force-pushed
the
fixup_size_plotting
branch
from
79ee9ef
to
cf909d1
Compare
nilsvu
approved these changes
Feb 20, 2024
nilsvu
reviewed
Feb 20, 2024
| @@ -404,7 +408,8 @@ struct Size : tt::ConformsTo<protocols::ControlError> { | |||
| ? std::optional<double>(control_error_delta_r - | |||
| delta_r_drift_outward_options_.value() | |||
| .outward_drift_velocity - | |||
| (lambda_00 + horizon_00 - | |||
| (lambda_00 + | |||
| spherepack_factor * horizon_00 - | |||
There was a problem hiding this comment.
Question: how severe is this bug? what impact did it have on simulations?
There was a problem hiding this comment.
None. In all of my runs I've disabled the delta_r_drift_outward option since we haven't needed it.
An older version didn't output the smoother timescale
knelli2
force-pushed
the
fixup_size_plotting
branch
from
cf909d1
to
6d91039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Also add a missing SPHEREPACK factor to the calculation of the average delta R (and a comment explainin why).
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments