Add Rk3Pareschi IMEX time stepper #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teukolsky
reviewed
Feb 14, 2024
| // | ||
| // Not given in the reference. Any set of coefficients of the form | ||
| // (0, 0, x, x, 1 - 2 x) works. | ||
| {0.0, 0.0, 0.0, 0.0, 1.0}, |
There was a problem hiding this comment.
It's probably better to use a non-zero value of x so the error estimate samples the y-values across the interval. x=1/4 looks good. Using only the last value is probably not robust. This is the reason, by the way, that Dormand-Prince is 853 and not, say 87 or 86. These 'simpler' error estimates turned out not to sample the interval very well.
nilsdeppe
requested changes
Feb 27, 2024
| namespace TimeSteppers { | ||
| /*! | ||
| * \ingroup TimeSteppersGroup | ||
| * \brief A fourth-order Runge-Kutta method with IMEX support. |
wthrowe
force-pushed
the
imex/Rk3Pareschi
branch
from
ffbc717
to
1a33990
Compare
nilsdeppe
approved these changes
Feb 28, 2024
|
CI failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to @yoonso0-0: I've renamed the class since the last version I gave you.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments