Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing when FPEs are reenabled #5983

Closed
wthrowe opened this issue May 10, 2024 · 2 comments
Closed

Tests failing when FPEs are reenabled #5983

wthrowe opened this issue May 10, 2024 · 2 comments
Assignees
Labels
priority critical for progress

Comments

@wthrowe
Copy link
Member

wthrowe commented May 10, 2024

When RunTests was split into multiple executables, a chunk of the initialization code was lost, most notably enabling FPEs in most of the unit tests. I've reenabled then in #5982, but this causes tests to fail. This issue is to organize getting those fixed so the PR can be merged. I've attempted to identify the causes of the failing tests and who made the changes. Apologies if I've misidentified a cause. You should be able to reproduce the problem by checking out my PR.

@isaaclegred:

  • Unit.GrMhd.ValenciaDivClean.PrimitiveFromConservative - overflow in Kastaun

@knelli2:

  • Unit.ControlSystem.TimescaleTuner - overflow when decrease_timescale_threshold is large

@nilsdeppe:

  • Unit.Evolution.Systems.GhValenciaDivClean.Subcell.FixConsAndComputePrims - SIMD
  • Unit.Evolution.Systems.ValenciaDivClean.Subcell.FixConsAndComputePrims - SIMD
  • Unit.Evolution.GrMhd.ValenciaDivClean.FixConservatives - SIMD
  • Unit.Numerical.RootFinding.TOMS748 - presumably related to the SIMD rewrite, although the first failure is not in SIMD code

@Sizheng-Ma:

  • Unit.Evolution.Systems.Cce.Actions.KleinGordonH5BoundaryCommunication - sets the final time to NaN

Don't know:

  • Unit.Evolution.Systems.ValenciaDivClean.Subcell.TciOnDgGrid - underflow in Kastaun
@nilsdeppe
Copy link
Member

#6265 I think generally addressed this. There were a couple MC tests I had to disable, but we are not using that code in any evolution and the issues will need to get resolved for that anyway.

@wthrowe are you okay closing this as done?

@wthrowe
Copy link
Member Author

wthrowe commented Sep 11, 2024

Yeah, this is done.

@wthrowe wthrowe closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority critical for progress
Projects
None yet
Development

No branches or pull requests

5 participants