-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Show size in byte #1261
base: master
Are you sure you want to change the base?
Conversation
Sorry for ignoring this for so long! Would you perhaps like to rebase this? I promise I'll review it quickly. :) |
OK |
39c9264
to
cb0dd89
Compare
I'm done |
Ok, so I'm thinking: Perhaps this should be a frontend option like the sorting method and sorting order? It would be consistent since it's a display thing like those other options. There could be a button in the "Size" row that would allow you to toggle this (and it'd change the query parameter). We can still have something like |
Agreed! Keeping it consistent with sorting options and adding a toggle in the “Size” row makes sense. I’m good with the --default-size-display flag too. |
Add a cli option that show file size in bytes rather than KB or MB, etc.
cb0dd89
to
a5c32b5
Compare
It seems there is no suitable place for the button in the table header, I think the |
Add a cli option that show file size in bytes rather than KB or MB, etc.
solve the #1236.