Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show size in byte #1261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lzzzzzt
Copy link

@Lzzzzzt Lzzzzzt commented Oct 28, 2023

Add a cli option that show file size in bytes rather than KB or MB, etc.
solve the #1236.

@svenstaro
Copy link
Owner

Sorry for ignoring this for so long! Would you perhaps like to rebase this? I promise I'll review it quickly. :)

@Lzzzzzt
Copy link
Author

Lzzzzzt commented Sep 22, 2024

Sorry for ignoring this for so long! Would you perhaps like to rebase this? I promise I'll review it quickly. :)

OK

@Lzzzzzt
Copy link
Author

Lzzzzzt commented Sep 22, 2024

Sorry for ignoring this for so long! Would you perhaps like to rebase this? I promise I'll review it quickly. :)

I'm done

@svenstaro
Copy link
Owner

Ok, so I'm thinking: Perhaps this should be a frontend option like the sorting method and sorting order? It would be consistent since it's a display thing like those other options. There could be a button in the "Size" row that would allow you to toggle this (and it'd change the query parameter).

We can still have something like --default-size-display which is either human or exact. What do you think about that?

@Lzzzzzt
Copy link
Author

Lzzzzzt commented Oct 12, 2024

Ok, so I'm thinking: Perhaps this should be a frontend option like the sorting method and sorting order? It would be consistent since it's a display thing like those other options. There could be a button in the "Size" row that would allow you to toggle this (and it'd change the query parameter).

We can still have something like --default-size-display which is either human or exact. What do you think about that?

Agreed! Keeping it consistent with sorting options and adding a toggle in the “Size” row makes sense. I’m good with the --default-size-display flag too.

Add a cli option that show file size in bytes rather than KB or MB, etc.
@Lzzzzzt
Copy link
Author

Lzzzzzt commented Oct 13, 2024

There could be a button in the "Size" row that would allow you to toggle this (and it'd change the query parameter).

It seems there is no suitable place for the button in the table header, I think the Size string in the entry could be a button to change the display behavior. And this will change other entries' display behavior, not only the clicked one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants