Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary awaits #13066

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore: remove unnecessary awaits #13066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/kit/test/apps/basics/test/cross-platform/client.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,13 +633,13 @@
await page.goto('/routing/hashes/a');

await clicknav('[href="#preload"]');
await expect(page.url()).toBe(`${baseURL}/routing/hashes/a#preload`);
expect(page.url()).toBe(`${baseURL}/routing/hashes/a#preload`);

await clicknav('[href="/routing/hashes/a"]');
await expect(page.url()).toBe(`${baseURL}/routing/hashes/a`);
expect(page.url()).toBe(`${baseURL}/routing/hashes/a`);

await clicknav('[href="#preload"]');
await expect(page.url()).toBe(`${baseURL}/routing/hashes/a#preload`);
expect(page.url()).toBe(`${baseURL}/routing/hashes/a#preload`);
});

test('does not rerun load on calls to duplicate preload hash route', async ({ app, page }) => {
Expand Down Expand Up @@ -820,7 +820,7 @@
expect(await page.textContent('h3')).toBe('bar');
});

test('responds to <form target="_blank"> submission with new tab', async ({ page }) => {

Check warning on line 823 in packages/kit/test/apps/basics/test/cross-platform/client.test.js

View workflow job for this annotation

GitHub Actions / test-kit-cross-browser (18, ubuntu-latest, firefox, build)

flaky test: responds to <form target="_blank"> submission with new tab 

retries: 2
await page.goto('/routing/form-target-blank');

let tabs = page.context().pages();
Expand All @@ -834,7 +834,7 @@
expect(tabs.length > 1);
});

test('responds to <button formtarget="_blank" submission with new tab', async ({ page }) => {

Check warning on line 837 in packages/kit/test/apps/basics/test/cross-platform/client.test.js

View workflow job for this annotation

GitHub Actions / test-kit-cross-browser (18, ubuntu-latest, firefox, build)

flaky test: responds to <button formtarget="_blank" submission with new tab 

retries: 2
await page.goto('/routing/form-target-blank');

let tabs = page.context().pages();
Expand Down
Loading