Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary awaits #13066

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore: remove unnecessary awaits #13066

merged 1 commit into from
Nov 28, 2024

Conversation

benmccann
Copy link
Member

I had warnings on these lines in VS Code

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 4fbdca5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

This doesn't seem like a good idea unless we know exactly what's going on. I wouldn't just trust VS Code squigglies for something like this. Playwright's expect() is very often async. What makes it sync in this case?

@benmccann
Copy link
Member Author

this is correct. playwright's async expects are for when you're using one of their locators and are waiting for some element to have some state. this isn't using the locator api. it's just checking the current page URL which doesn't require waiting for anything

@eltigerchino eltigerchino merged commit 10d0942 into main Nov 28, 2024
14 checks passed
@eltigerchino eltigerchino deleted the no-await branch November 28, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants