Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify load rerun behavior #10508

Closed
wants to merge 3 commits into from
Closed

Conversation

coryvirok
Copy link
Contributor

Based on the conversations here:

Any changes to the URL will cause any load functions that access url.searchParams to be rerun even if the search portion of the URL has not changed (or indeed if there are no search params in the URL.)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Based on the conversations here:
- sveltejs#10504
- sveltejs#8403

Any changes to the URL will cause any `load` functions that access `url.searchParams` to be rerun even if the search portion of the URL has not changed (or indeed if there are no search params in the URL.)
Update 20-load.md to clarify load rerun behavior
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

⚠️ No Changeset found

Latest commit: 7214881

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title Update 20-load.md to clarify load rerun behavior docs: clarify load rerun behavior Aug 9, 2023
@benmccann benmccann added the documentation Improvements or additions to documentation label Aug 9, 2023
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
@benmccann
Copy link
Member

hmm. are we sure this isn't a bug? I don't think we should document it if the behavior is unexpected / wrong

@coryvirok
Copy link
Contributor Author

I think the consensus is that this is a bug but the fix is not yet planned. Maybe we can document it but highlight it as a bug and link to the GH issues? The challenge with not documenting the current behavior is that it's fairly difficult to find unless you know what to look for, e.g. "load", "invalidate", "url.searchParams", etc. in GH.

I'm hoping that the priority for a fix is elevated since the original bug addressed changing search params that were supposed to be handled by different layouts and the bug I filed is a more generic (and IMO more likely to occur) issue that happens even if the search param is not provided at all.

cc @dummdidumm

@benmccann
Copy link
Member

I don't think we want to add something to the docs for every issue that's in the issue tracker. It'd be better to just fix the issue

@benmccann benmccann closed this Aug 9, 2023
@coryvirok
Copy link
Contributor Author

Any update on if this issue is on the roadmap? This is blocking some advanced functionality for my app and I cannot find a way around it without needing to change the pathname structure of my URLs, (in order to move the search param into a route param.)

The linked issue has it as low priority - p3-edge-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants