Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #5

Open
svartalf opened this issue Mar 11, 2019 · 8 comments · May be fixed by #16
Open

Windows support #5

svartalf opened this issue Mar 11, 2019 · 8 comments · May be fixed by #16
Assignees
Labels
C-enhancement New feature or request O-windows Operating system: Windows

Comments

@svartalf
Copy link
Owner

This is a tracking issue for Windows support.

Main problem is that termion backend for tui dependency does not support Windows terminals.

Another option for tui - crossterm supports Windows and should be considered as a replacement.

@svartalf svartalf added C-enhancement New feature or request O-windows Operating system: Windows labels Mar 11, 2019
@svartalf
Copy link
Owner Author

Possible switch to crossterm is blocked by this issue: crossterm-rs/crossterm#81 (I think), since it is important for battop to handle , and ^C key combinations.

@svartalf svartalf self-assigned this Apr 11, 2019
@svartalf
Copy link
Owner Author

Note to myself: blocking PR was closed, nothing should block windows support now.

svartalf added a commit that referenced this issue Apr 13, 2019
@svartalf
Copy link
Owner Author

And it is blocked by this PR now: fdehau/tui-rs#150

@svartalf
Copy link
Owner Author

Almost done, blocked only because there is no tui crate release with the changes from this PR: fdehau/tui-rs#153

@bew
Copy link

bew commented Feb 9, 2021

Hello, just discovered this nice tool!
Is it still blocked? 🙄

@svartalf
Copy link
Owner Author

svartalf commented Feb 9, 2021

No, it is not blocked anymore, switch to crossterm backend for tui should be done, but I don't really have time to do that now.

PRs are more that welcome!

@ratijas
Copy link

ratijas commented Mar 12, 2021

Interesting to the point at which I'm almost willing to give it a try.

What was the whole point, again? Terminal UI library, which is being used now, provides too much capabilities that cannot be replicated on Windows, so devs just gave on supporting it, and thus it fails to even compile? So we need to move on to a less capable library which would support the lowest common denominator of all platforms. Am I getting this right?

@svartalf
Copy link
Owner Author

@ratijas the idea is to pick up terminal UI library, which will provide the same interface (or, at least the almost same) as in the current implementation, while also providing support for at least Linux, macOS and Windows. If it will also support *BSD family, that will be a great bonus.

I'm not aware about current state of termion crate, but the idea to switch to crossterm still stands.

Does this answers your question?

@moko256 moko256 linked a pull request Jan 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request O-windows Operating system: Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants