fix: use batches for queue #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4689058586
💛 - Coveralls |
fenos
force-pushed
the
queue/use-batches-for-webhook
branch
from
129938e
to
2b10ce3
Compare
inian
approved these changes
Apr 13, 2023
| const { webhookURL, webhookApiKey, webhookQueuePullInterval } = getConfig() | ||
| const { webhookURL, webhookApiKey, webhookQueuePullInterval, webhookQueueBatchSize } = getConfig() | ||
|
|
||
| const httpClient = rateLimit(axios.create(), { maxRPS: 100 }) |
There was a problem hiding this comment.
we should probably make this an env var
| @@ -46,6 +46,20 @@ export abstract class BaseEvent<T extends Omit<BasePayload, '$version'>> { | |||
| return {} | |||
| } | |||
|
|
|||
| static ack(job: Job<BaseEvent<any>['payload']> | Job<BaseEvent<any>['payload']>[]) { | |||
There was a problem hiding this comment.
complete is a better word for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the new behavior?
Use batches when for webhook queue