Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use custom sinks outside of the crate #62

Closed
2 tasks done
mfzl opened this issue Nov 25, 2024 · 1 comment
Closed
2 tasks done

Unable to use custom sinks outside of the crate #62

mfzl opened this issue Nov 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mfzl
Copy link
Contributor

mfzl commented Nov 25, 2024

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

The Sink trait expects to return resumption state

async fn get_resumption_state(&mut self) -> Result<PipelineResumptionState, SinkError>; but right now properties of the struct are set to private.

To Reproduce

Try to use any custom sink with the pipeline

Expected behavior

Must be able to implement custom sinks
@mfzl mfzl added the bug Something isn't working label Nov 25, 2024
@mfzl mfzl mentioned this issue Nov 25, 2024
Merged
@imor
Copy link
Contributor

imor commented Nov 25, 2024

Fix in #61 merged.

@imor imor closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imor @mfzl