Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to bypass BigQuery's 10 MB payload limit #54

Open
imor opened this issue Nov 4, 2024 · 2 comments
Open

Add retries to bypass BigQuery's 10 MB payload limit #54

imor opened this issue Nov 4, 2024 · 2 comments

Comments

@imor
Copy link
Contributor

imor commented Nov 4, 2024

If the payload to the AppendRows call is greater than 10 MB, BigQuery will reject the call. Detect this and retry with the payload half the original size. Continue this logarithmic halving until the requests succeed. Also collect the retry data as metrics to tune the buffer sizes and retries.

@Ziinc
Copy link

Ziinc commented Nov 14, 2024

Isn't it easier to cap the batches to like 8MB? That is the current logflare approach.

@imor
Copy link
Contributor Author

imor commented Nov 22, 2024

@Ziinc can you share the logflare code where this is done? What exactly do you cap to 8MB? Is it the payload serialized in the protobuf format? Or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants