feat(websocket): Change library to websocketpp #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summershrimp
force-pushed
the
migrate_websocketpp
branch
from
fe45a6d
to
df778ef
Compare
Closed
Closed
obs-studio release doesn't carrying with QWebSocket library. Before we build our own one and distribute. But QT libraries cannot compatible across version. So everytime obs-studio upgrade their QT version, we need to recompile and distribute QWebSockets. After changing to websocketpp, we won't carrying QWebSockets and the version of our plugins can suit obs version more widely. Signed-off-by: Yibai Zhang <xm1994@gmail.com>
summershrimp
force-pushed
the
migrate_websocketpp
branch
14 times, most recently
from
b78252f
to
a520147
Compare
summershrimp
force-pushed
the
migrate_websocketpp
branch
2 times, most recently
from
8262552
to
a447a3f
Compare
Signed-off-by: Yibai Zhang <xm1994@gmail.com>
summershrimp
force-pushed
the
migrate_websocketpp
branch
from
a447a3f
to
8dde34a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obs-studio release doesn't carrying with QWebSocket library. Before we build our own one and distribute. But QT libraries cannot compatible across version. So everytime obs-studio upgrade their QT version, we need to recompile and distribute QWebSockets.
After changing to websocketpp, we won't carrying QWebSockets and the version of our plugins can suit obs version more widely.