Improve time interval pickers #282
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent use of S.of(context). * Add test code. * Fix dangerfile. * Check only dart files. * Revert "Add test code." This reverts commit bd975da * Move remote_config import back
* Added myself to contributers * Added myself to contributers * Added myself to contributers * Added myself to contributers * Added myself to contributers * Added myself to contributers(+ Ș/ț) Co-authored-by: stafy2912 <stafy2912@gmail.com>
…/acs-upb-mobile into andreew/update_contributors
* Sort people by last name. * Bump build number. Co-authored-by: Andrei-Constantin Mirciu <38398944+andreicmirciu@users.noreply.github.com>
* update_contributors * Update pubspec.lock * Update README.md
Stefan Popa - Update Contributors
* Allow unsafe traffic from aii.pub.ro. * Only allow HTTP fo aii.pub.ro. * Fix some whitespace. * Bump version. * Allow HTTP on iOS as well. * Indent Info.plist using tabs. * Missed a tab.
* Remove bottom blue line in tab bar. * Change SelectableFormField to use Chips. * Improve Chip theme. * Make dividers more consistent. Couldn't find the exact setting but this looks decent. * Add custom theme for dark mode. * First attempt at fixing relevance picker. * Fix logic for relevance picker. * Select "Anyone" when no custom node is selected. * Call relevancePicker.onChanged whenever it changes. * Disable public filter options if user doesn't have permission. * Fix ChoiceChip theme. * Make RelevancePicker a FormField everywhere. * Reuse ChipFormField in RelevanceFormField. * Move filterIconColor to resources/theme.dart. * Remove some duplicate code. * Remove S.of(context). * Fix default relevance in picker. * Use chips on filter page. This also fixes #5. * Use chips in FAQ page. * Fix tests. * Make flutter version in workflows more specific. Workflows now fail on GH but work locally, so I think it's because the 1.24.x version somehow gets matched to 2.3.0-24.1.pre-beta instead of 1.24.0-10.2.pre. * Revert workflow changes. No longer seems to be necessary and the previous version didn't work well anyway. * Prep for release. * Bump version and update changelog. * Add comma for formatting. Co-authored-by: Andrei-Constantin Mirciu <38398944+andreicmirciu@users.noreply.github.com>
Solved warnings Updated related packages
Solved warnings Updated related packages
(in timetable's model classes)
Created event provider function (getEventsIntersecting), currently from already existing methods. Made necessary conversions to UTC time zone.
Events are now preloaded including previous and next page (a page is a week). Fixed minor warnings
To be improved, since I believe I also convert already-UTC DateTimes.
…fDay subtraction method
Fixed overflow on text from all-day events Refactoring
This is done by updating isUtc property for events without making hour conversions; those would shift the hour from midnight to ~9PM previous. day.
However, it turned out that, while converting to Firebase Timestamp, I had to disable isUtc property to avoid an off-by-two-hours error (see toNonUtcForced() )
…nt with the Timetable package
- RemoteConfig is not supported on web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating to Flutter 2 (#195), I made a list of packages we need to replace with null safe equivalents. Among these was
interval_time_picker, which I thought we were using in the event time picker.Turns out, we weren't actually using it, but since I had already started, I added functionality to open a duration picker when tapping the time interval duration on the add event page:
Now initially the colour didn't fit with our app's colour, so I fiddled around with colour schemes to fix it (and I also noticed the time picker colours didn't match either; now they do).
The base branch for this is null_safety_fixes, so this should only be merged once #280 is merged.