Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Let the user confirm installation of each app after they saw app's size #57

Open
farooqkz opened this issue Oct 31, 2020 · 20 comments
Open
Labels
enhancement New feature or request

Comments

@farooqkz
Copy link
Collaborator

No description provided.

@strukturart
Copy link
Owner

we don't know the size of the app

@strukturart
Copy link
Owner

in this ann I can only display what is in the database. if you want blue water gushing out of the spring you have to dig deep in the mountain.

@farooqkz
Copy link
Collaborator Author

We can ask from the HTTP server if it tells us about size. Want me to send a PR?

@farooqkz
Copy link
Collaborator Author

farooqkz commented Nov 1, 2020

@strukturart If you agree on adding this feature, I can send a PR.

@farooqkz farooqkz added the enhancement New feature or request label Nov 15, 2020
@farooqkz
Copy link
Collaborator Author

Why this was closed? Did you implement this thing in the store app?

@strukturart
Copy link
Owner

I've been waiting for you to send me something ...... not come ...... issue closed

@farooqkz
Copy link
Collaborator Author

@strukturart An issue requesting a feature may be closed only when the developer(s) reject adding that feature or when the feature is added. It seems that you are not rejecting so I reopen this issue for now till someone(me or you or anyone else) add this feature.

Also you have waited for me without informing me about this matter and at the same time I was waiting for an approval from you!

@farooqkz farooqkz reopened this Nov 25, 2020
@strukturart
Copy link
Owner

strukturart commented Nov 25, 2020

I think the information about the file size should be in the database and not the task of the client to determine it.

https://gitlab.com/banana-hackers/store-db/-/blob/master/_generator/index.js

@farooqkz
Copy link
Collaborator Author

It's not in the DB but why don't we inform the user about file size like any other downloader?

@strukturart
Copy link
Owner

Informing the user is the task of the client, I can do that.

@farooqkz
Copy link
Collaborator Author

Do you know how should you do that?

@strukturart
Copy link
Owner

please adapt the generator file so that the file size is determined

@farooqkz
Copy link
Collaborator Author

Nope. Let me do it myself. Give me a few days but less than a week :)

@strukturart
Copy link
Owner

hmh, if it is in the database, other clients can also use the information

@farooqkz
Copy link
Collaborator Author

Let's discuss this in Discord so that others can participate

@strukturart
Copy link
Owner

@Simon-Laux pls add the filesize into the store db

@farooqkz
Copy link
Collaborator Author

He has said that such a thing won't be added!

@strukturart
Copy link
Owner

okay, that would be the right place in the db so that the information is available to all clients. @farooqkz could you send me a snippet that i do it in the client

@farooqkz
Copy link
Collaborator Author

@Simon-Laux
Copy link
Collaborator

@Simon-Laux pls add the filesize into the store db

read the discord backlog we discussed this there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants