Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StreetComplete registered for josm: links? #6028

Closed
matkoniecz opened this issue Nov 26, 2024 · 6 comments
Closed

Make StreetComplete registered for josm: links? #6028

matkoniecz opened this issue Nov 26, 2024 · 6 comments
Labels
feedback required more info is needed, issue will be likely closed if it is not provided wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@matkoniecz
Copy link
Member

It would become possible to open it (once installed) from edit button at osm.org, if See openstreetmap/openstreetmap-website#5351 would be merged.

@westnordost
Copy link
Member

westnordost commented Nov 26, 2024

What? Why josm:? If StreetComplete was to be added to the [Edit] button on OSM.org, might as well have streetcomplete: as a scheme. Or rather, https://streetcomplete.app?<some parameters> as this will also work when the user didn't install the app yet. (Coming from the browser, streetcomplete.app links are opened in StreetComplete if it is installed)

Also, I thought policy was that only "fully featured" editors are shown behind that edit button?
Also, SC discourages users to edit random places, it would be inconsequential to then display it to edit any location, wouldn't it?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 26, 2024
@AntonKhorev
Copy link

Why josm:?

Ask Vespucci developers https://vespucci.io/tutorials/vespucci_intents/#supported-intents

Of course it only makes sense for apps that support (a subset of) remote control commands. But maybe everyone can agree to support load_and_zoom. Then we can have an URI scheme that would run any editor registered by the system on the user's end.

@HolgerJeromin
Copy link
Contributor

Opening SC via geo uri on osm.org already works...

@AntonKhorev
Copy link

With geo uris you have to choose an editing app from the list of all apps that can do something with coordinates.

load_and_zoom can pass an exact bounding box and an osm element.

@westnordost
Copy link
Member

Neither of these make sense for StreetComplete, though.

@westnordost
Copy link
Member

westnordost commented Nov 27, 2024

So, basically, first it should be a policy decision by openstreetmap-website maintainers (or OSMF??) whether to include any editor software that are not (mostly) fully-fledged general-purpose editors on their respective platform (JOSM, iD, Vespucci, Go Map!!).

If adding other editor software is fine, I would be happy to implement whatever makes sense for such a link to StreetComplete. For example, it is conceivable to directly activate a certain overlay (e.g. Places overlay, things overlay, cycleway overlay, ...) and/or preset(s), and instead link to streetcomplete.app if the user hasn't installed StreetComplete yet.

Until then, this is a will not fix because 1. see @HolgerJeromin and 2. see my previous comment.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
@riQQ riQQ added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

5 participants