ETH-795: Export chain-related types along with the config #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtakalai
requested changes
Nov 4, 2024
There was a problem hiding this comment.
problem with removing ""s from the rawConfig is now it's not JSON anymore. Even better would be to put it into a separate json file (which is valid JSON), then read from there and give correct types for typescript. We want non-JS/TS languages be able to read this config as well.
mondoreale
commented
Nov 4, 2024
| @@ -1,462 +1,547 @@ | |||
| export const config = { | |||
There was a problem hiding this comment.
@jtakalai this wasn't JSON before already. What's your idea on moving forward?
- Do you want to expose
config.json? - Do you want to have a
config.jsonnext toconfig.jsso people can decide (or straight up copy-paste)?
lmk
Cheers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.