Remote control #249
Open
Remote control #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dselans
approved these changes
Mar 29, 2022
| @@ -74,6 +82,8 @@ func (p *Plumber) RunServer() error { | |||
| p.log.Error(errors.Wrap(err, "failed to relaunch tunnels")) | |||
| } | |||
|
|
|||
| go p.runRemoteControl() | |||
There was a problem hiding this comment.
Should remote control be elective? It can be enabled by default but should be possible to disable.
| @@ -89,6 +99,119 @@ func (p *Plumber) RunServer() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (p *Plumber) runRemoteControl() bool { | |||
| if !p.CLIOptions.Server.RemoteControlEnabled { | |||
| // Reconnected successfully, exit out of this goroutine | ||
| // Another one will be started for the new connection in runRemoteControl() | ||
| return | ||
| } |
There was a problem hiding this comment.
What happens when all reconnects (with backoff) fail?
There was a problem hiding this comment.
@dselans It will continue to retry with the highest interval, in this case, every 5 minutes. Since this will be running in server mode, I think we just want it to retry indefinitely right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.