Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing Delegating Wallet to createSetPermissionSignature #224

Open
jacob-tucker opened this issue Jul 25, 2024 · 0 comments
Open

Passing Delegating Wallet to createSetPermissionSignature #224

jacob-tucker opened this issue Jul 25, 2024 · 0 comments

Comments

@jacob-tucker
Copy link
Contributor

I have a DApp where the Admin should be able to control a creator's IP Assets. The creator wallets are created & controlled by the DApp. To do this, I want the Admin to call the executeWithSig on the creator's IP Account, using the creator's signature, in order to set all permissions so that the admin can fully control the creator's IP Asset

I tried looking into createSetPermissionSignature, but I believe there is an issue with it. In this function, this.wallet is the Admin's account because they are the one sending the transaction. However on this line, this.wallet is also used to generate the signature, but I believe it should be the creator's wallet instead because they are the one granting permission.

In summary, we should add an argument to createSetPermissionSignature that accepts user's Wallet, so we can sign with that wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant