Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument all non-trivial functions with monkit's Task #37

Open
amwolff opened this issue Oct 11, 2021 · 4 comments
Open

Instrument all non-trivial functions with monkit's Task #37

amwolff opened this issue Oct 11, 2021 · 4 comments
Labels
edge enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up for grabs

Comments

@amwolff
Copy link
Member

amwolff commented Oct 11, 2021

We added the hacktoberfest label to issues we considered a good fit for 2021's Hacktoberfest. If you want to work on this issue, let us know in the discussion below, so we can remove the up for grabs label and avoid having people working on the same issue independently, making sure no one's work goes in vain. Please also consider discussing how you would like to approach the problem, if appropriate. Thank you for contributing!


We use monkit to monitor most of our code. Every function/method that is not trivial or performance-critical, especially from the object layer, should be instrumented with monkit's Task, e.g.

var mon = monkit.Package()

...

func (s service) RemoveExpiredUsers(ctx context.Context) (err error) {
	defer mon.Task()(&ctx)(&err)

	...

}

Read more about monkit here.

@amwolff amwolff added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest up for grabs labels Oct 11, 2021
@avinilcode
Copy link
Contributor

@amwolff Can i take it up?
Just today is left, will try to be quick

@amwolff
Copy link
Member Author

amwolff commented Oct 31, 2022

@avinilcode Yes, feel free to send us a Pull Request! Thanks :)

avinilcode added a commit to avinilcode/gateway-st that referenced this issue Oct 31, 2022
@avinilcode
Copy link
Contributor

@amwolff please review, i have raised one pull request, thanks :)

avinilcode added a commit to avinilcode/gateway-st that referenced this issue Nov 1, 2022
@amwolff amwolff added the edge label Dec 15, 2022
@ferristocrat
Copy link

Was this completed/merged @amwolff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edge enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up for grabs
Projects
None yet
Development

No branches or pull requests

3 participants