Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support SSR #33

Open
abnud1 opened this issue Aug 30, 2020 · 2 comments
Open

support SSR #33

abnud1 opened this issue Aug 30, 2020 · 2 comments
Assignees
@gosolivs
Labels
enhancement New feature or request

Comments

@abnud1
Copy link

abnud1 commented Aug 30, 2020

Right now this module can't be used on server for SSR because it relies on window object and location object
and doesn't provide any alternative for server
@gosolivs gosolivs self-assigned this Aug 30, 2020
@gosolivs gosolivs added the enhancement New feature or request label Aug 30, 2020
@gosolivs
Copy link
Member

I agree. If it is a separate file for the server with the same public API. Is this normal?

@abnud1
Copy link
Author

abnud1 commented Aug 30, 2020

I agree. If it is a separate file for the server with the same public API. Is this normal?

Creating the same routes two times: one on server and one on client should not be considered normal

I'm ok to have different code on server than client, just not redefine routes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosolivs gosolivs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gosolivs @abnud1