-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added feature to add prefix in classes from setting tab #30
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and apologies for the late reply! I appreciate you taking the time to contribute to the project. I'm happy to approve the change to add prefixes to the classes from the settings tab: However, some of the other commits seem a bit out of scope for this PR. I would recommend opening separate pull requests for those changes if they are needed. So if you could update this PR (or create a new PR) to be the single Thank you again! (As a quick aside, I should also note that I will not be able to merge changes that add Google tracking.) |
if(settings.classPrefix != ''){ | ||
tailWindStyles = tailWindStyles.map(element => { | ||
return settings.classPrefix+'-'+element | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fairly small points, I'll leave it up to you if you want to address them or not.
you may to use !== over != for strict equality
You may also want to consider updating the spacing on the if statements and add semicolons to match the set convention.
if (settings.classPrefix !== '') {
tailWindStyles = tailWindStyles.map(element => {
return settings.classPrefix + '-' + element;
});
}
Please take a look