Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete newly created comments #10

Open
stevelw opened this issue Nov 7, 2024 · 0 comments
Open

Can't delete newly created comments #10

stevelw opened this issue Nov 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@stevelw
Copy link
Owner

stevelw commented Nov 7, 2024

When I post a new comment then try to delete it immediately, it throws an error saying "Couldn't delete comment. Please try again later." This is because when posting a new comment, it's optimistic rendering, the newly posted comment does not have an id and so the api call will fail. Maybe make it not optimistic, only show it after the api call succeeds

Originally posted by @nc-scarlett-adams in #6 (review)

@stevelw stevelw added the bug Something isn't working label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant