Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Fornax constellation's lines include the constellation lines of the constellation Eridanus #113

Open
13-Characters opened this issue Nov 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@13-Characters
Copy link

13-Characters commented Nov 12, 2024

Describe the bug
When rendering only the constellation lines of the constellation Fornax, the constellation lines of Eridanus and Fornax both display.

To Reproduce
By running these lines of code, I found that the constellation lines for Fornax are not correct.

from starplot import MapPlot, Projection
from starplot import Constellation

# Draco
p = MapPlot(
    projection=Projection.LAMBERT_AZ_EQ_AREA,
    ra_min=1,
    ra_max=5.5,
    dec_min=-60,
    dec_max=5,
)
p.constellations(labels=None, where=[Constellation.constellation_id=='for']) # show Fornax constellation lines only
p.stars(mag=6, labels=None)
p.gridlines(labels=True)
p.export("charts/fornax_chart.png")

Expected behavior
I expected fornax_chart.png to look like this:
image
and I expected eridanus_chart.png to look like this:
image

Screenshots
Instead, fornax_chart.png looks like this:
fornax_chart
and replacing p.constellations(labels=None, where=[Constellation.constellation_id=='for']) with p.constellations(labels=None, where=[Constellation.constellation_id=='eri']) results in this image:
eridanus_chart

Environment Details (please complete the following information):

  • Starplot version: v0.12.3
  • Python version: 3.10
  • Matplotlib version: 3.9.2
  • OS: Windows
@steveberardi
Copy link
Owner

ahh, this is a bug in the constellations data. It's happening because the center of Fornax and/or Eridanus are incorrect. I'll add this to the roadmap to fix 👍 For now, a workaround to get the result you're looking for is to use the Constellation's iau_id field instead:

p.constellations(
    labels=None,
    where=[Constellation.iau_id == 'for'],
)

Thanks for reporting this!

@steveberardi steveberardi added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants