Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target pointer width rather than x86 #26

Open
tgross35 opened this issue Apr 5, 2024 · 1 comment
Open

Use target pointer width rather than x86 #26

tgross35 opened this issue Apr 5, 2024 · 1 comment
Labels
question Further information is requested

Comments

@tgross35
Copy link

tgross35 commented Apr 5, 2024

The code

/// A word.
#[cfg(not(target_arch = "x86"))]
pub type Word = u64;
/// Doubled word.
#[cfg(not(target_arch = "x86"))]
pub type DoubleWord = u128;
/// Word with sign.
#[cfg(not(target_arch = "x86"))]
pub type SignedWord = i128;
/// A word.
#[cfg(target_arch = "x86")]
pub type Word = u32;
/// Doubled word.
#[cfg(target_arch = "x86")]
pub type DoubleWord = u64;
/// Word with sign.
#[cfg(target_arch = "x86")]
pub type SignedWord = i64;
has a lot of code that is configured based on x86 or not(x86). Is there a reason that x86 is special, or could this instead use #[cfg(target_pointer_width = 64)]/#[cfg(target_pointer_width = 32)]?

@stencillogic
Copy link
Owner

Basically, the library only supports x64 and x86. Hence it uses just x86 and not(x86) here and there. It was tested for ARM once, but in general ARM is not supported at the moment.

@stencillogic stencillogic added the question Further information is requested label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants