Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-change check to build-fuzz and docs builds #1383

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 24, 2024

What

Add no-change checks to the build-fuzz and docs builds, that errors if there are any changes to the working directory after the builds run.

Why

To detect files that weren't generated or updated relating to builds. Also checks the lock file is up to date.

We could alternative use options on cargo to freeze the lock file, which is another way to achieve same for that one file. However, this more general check will check any files that changes as part of build, so it's broader.

@leighmcculloch leighmcculloch requested a review from a team October 24, 2024 11:55
@leighmcculloch leighmcculloch marked this pull request as ready for review October 24, 2024 11:55
@leighmcculloch leighmcculloch added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 433ce5c Oct 24, 2024
16 checks passed
@leighmcculloch leighmcculloch deleted the endable-layery branch October 24, 2024 21:26
@leighmcculloch leighmcculloch linked an issue Oct 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo.lock can change in ci
2 participants