Fill gaps in ref conversions to Val #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmm I think this is mostly-ok but I also think that since it's an impl of a public type and a public trait it falls under a major semver change? Maybe? |
|
It does, but that's okay, it's targeting the v22 major release because it's required for the SDK changes being made for constructors. |
dmkozh
approved these changes
Oct 31, 2024
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Nov 1, 2024
### What
Add ContractArgs for building function args.
### Usage
```diff
-let contract_id = env.register(Contract, (100_u32, 1000_i64));
+let contract_id = env.register(Contract, ContractArgs::__constructor(&100_u32, &1000_i64));
```
### Diff of generated code for constructor test vector
```diff
@@ -7,6 +7,8 @@ extern crate core;
extern crate compiler_builtins as _;
use soroban_sdk::{contract, contractimpl, contracttype, Env};
pub struct Contract;
+///ContractArgs is a type for building arg lists for functions defined in "Contract".
+pub struct ContractArgs;
///ContractClient is a client for calling the contract defined in "Contract".
pub struct ContractClient<'a> {
pub env: soroban_sdk::Env,
@@ -210,6 +212,17 @@ impl<'a> ContractClient<'a> {
res
}
}
+impl ContractArgs {
+ pub fn __constructor<'i>(
+ init_key: &'i u32,
+ init_value: &'i i64,
+ ) -> (&'i u32, &'i i64) {
+ (init_key, init_value)
+ }
+ pub fn get_data<'i>(key: &'i DataKey) -> (&'i DataKey,) {
+ (key,)
+ }
+}
#[doc(hidden)]
pub mod ____constructor {
use super::*;
```
### Why
To provide a way to make specifying args as concrete.
Dependent on:
- stellar/rs-soroban-env#1479
Close #1348
### Note
This is still very much an experiment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fill gaps in ref conversions to Val.
Why
Needed for: