Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: remove captive-core-use-db parameter #5537

Open
mollykarcher opened this issue Nov 20, 2024 · 0 comments
Open

services/horizon: remove captive-core-use-db parameter #5537

mollykarcher opened this issue Nov 20, 2024 · 0 comments

Comments

@mollykarcher
Copy link
Contributor

What problem does your feature solve?

Core team wants to remove support for in-memory mode. Core's -in-memory mode proxy's directing to our captive-core-use-db config param, which is currently deprecated, but still exists.

What would you like to see?

  • Remove the captive-core-use-db flag. Behavior should now be forced into "true" for this flag.
  • Remove anywhere else that we may pass the --in-memory flag to captive core
  • Remove the flag from any internal/external documentation
  • Update puppet deployments to remove the flag
  • Update k8s manifests/helm charts to remove the flag

Note that this is technically a breaking change so it should align with a protocol boundary. Core wants to make their corresponding breaking change in a minor version release. Ideally, this should wait for protocol 23, but pending outcome of slack discussion here if Core will defer their change.

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants