Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimbus t8n forkname+xxxx eip support #1607

Closed
winsvega opened this issue Jun 24, 2023 · 3 comments
Closed

Nimbus t8n forkname+xxxx eip support #1607

winsvega opened this issue Jun 24, 2023 · 3 comments
Labels
enhancement New feature or request hard

Comments

@winsvega
Copy link

Has Nimbus implemented eip1153?
Sometimes before the inclusion we use this schema Shanghai+1153 to tell that 1153 is to be activated on top of Shanghai rules.
This is because we don't know if 1153 is gonna be in Merge or Shanghai or Cancun
so the t8n allows to generate the tests for 1153 using the latest evm revision (Shanghai for instance)
And then when it is included we just rename it to Shanghai.
This is not possible for all eips but some.

@jangko
Copy link
Contributor

jangko commented Jun 25, 2023

We have an open PR #1401 exploring this possibility, but then I realize something that is very difficult to solve. Nimbus EVM opcode dispatcher is generated during compiletime, not at runtime. And the instruction table is generated for every hard fork. Runtime modification to this table is very difficult, because the static table need to be converted into a dynamic table, and the optimized codegen(to C) will dissapear.
Another hindrance is nimbus support for evmc, evmc API act as a barrier to this runtime EIP configuration.
If by any chance we can make 1401 to works, it probably only works for pure nim EVM, not the evmc.

@jangko jangko added the enhancement New feature or request label Jun 25, 2023
@winsvega
Copy link
Author

This feauture is not mandatory.
Whats important is to be able to have access to the evm as soon as eip is implemented

@jangko jangko added the hard label Aug 19, 2023
@jangko
Copy link
Contributor

jangko commented May 26, 2024

Due to technical reason, this feature will not be implemented in nimbus-eth1.

@jangko jangko closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hard
Projects
None yet
Development

No branches or pull requests

2 participants