You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the colors used in the print methods of STATcubeR only really work with dark editor themes. This is why there are setup-scripts like these to make the pkgdown-docs look nice despite having a light theme.
Since there is a substantial amount of R users using light editor themes, make sure that a freshly installed version of STATcubeR works with both light and dark editors. Additionaly, keep the current color palletes as a "dark-theme" and add some way to switch between the default theme and the dark theme. Simplify the pkgdown setup by just using the new default-theme.
Implementation
In order to make the theming system powerful engough to include all current "theme-adaptations" for pkgdown, it is necessary to provide
It would be possible to autodetect wether a light or dark mode is approprite via rstudioapi::getThemeInfo(). But this would be only applicable for rstudio users. It is probably better to provide a neutral theme, which works in dark and light editors as a default and make optimized themes for dark and light mode opt-in.
The text was updated successfully, but these errors were encountered:
Issue
Currently, the colors used in the print methods of
STATcubeR
only really work with dark editor themes. This is why there are setup-scripts like these to make the pkgdown-docs look nice despite having a light theme.STATcubeR/R/zzz.R
Lines 15 to 17 in 4537d3e
STATcubeR/vignettes/R/setup.R
Lines 5 to 7 in 99659dc
Challenge
Since there is a substantial amount of R users using light editor themes, make sure that a freshly installed version of STATcubeR works with both light and dark editors. Additionaly, keep the current color palletes as a "dark-theme" and add some way to switch between the default theme and the dark theme. Simplify the pkgdown setup by just using the new default-theme.
Implementation
In order to make the theming system powerful engough to include all current "theme-adaptations" for pkgdown, it is necessary to provide
{cli}
options. (possibly a bad idea, TBD)There is already some prototyping which uses theme-definitions in
inst/themes/{theme}.json
with the following structure.Defaults
It would be possible to autodetect wether a light or dark mode is approprite via
rstudioapi::getThemeInfo()
. But this would be only applicable for rstudio users. It is probably better to provide a neutral theme, which works in dark and light editors as a default and make optimized themes for dark and light mode opt-in.The text was updated successfully, but these errors were encountered: