Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better font family for integrated terminal #403

Closed
christian-bromann opened this issue Apr 11, 2023 · 2 comments
Closed

Use better font family for integrated terminal #403

christian-bromann opened this issue Apr 11, 2023 · 2 comments

Comments

@christian-bromann
Copy link
Contributor

Current Behavior

Given my VS Code Runme configurations:

"runme.experiments.grpcRunner": true
"runme.terminal.interactive": true
"runme.terminal.nonInteractive": true

If I run a code cell in interactive or non-interactive mode the terminal font is not a monospace one:

Screenshot 2023-04-11 at 13 22 19

Desired Behavior

I am not sure the origin of this problem. If I set-up VS Code incorrectly, I would like to see better docs on how this can be configured better. If my configuration is not at fault I would love to see Runme using a better default font family.

@mxsdev
Copy link
Contributor

mxsdev commented Apr 11, 2023

Discussed this, turns out VSCode has a fallback mechanism when the font isn't installed on the system, which the notebook terminal does not have.

One solution is to use the FontFaceSet API

Bromann pointed out if this isn't fixed it should be noted as part of stateful/runme.dev#119

@joseeantonior
Copy link

I'm unable to reproduce this as of today. However, if it's still an issue, let's reopen.

@joseeantonior joseeantonior closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants