Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize location specified by distance filter in Yelp searches #352

Open
gcampax opened this issue Jun 10, 2021 · 0 comments
Open

Recognize location specified by distance filter in Yelp searches #352

gcampax opened this issue Jun 10, 2021 · 0 comments
Labels
bug P3 Nice to have, not working on it for now release: main Issues that affect devices in the "main" release

Comments

@gcampax
Copy link
Contributor

gcampax commented Jun 10, 2021

If the user says "show me restaurants within XX of YY", we should extract the location and pass it to Yelp. Otherwise we pass the default location, which is Palo Alto, and the whole thing breaks.

This might require changes in ThingTalk re the query invocation hints for distance filters.
@gcampax gcampax added bug release: main Issues that affect devices in the "main" release labels Jun 10, 2021
@nrser nrser added the P3 Nice to have, not working on it for now label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug P3 Nice to have, not working on it for now release: main Issues that affect devices in the "main" release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrser @gcampax