Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L/R arrows for org and homepage #333

Open
7 tasks
ecurrencyhodler opened this issue Feb 29, 2024 · 6 comments
Open
7 tasks

Fix L/R arrows for org and homepage #333

ecurrencyhodler opened this issue Feb 29, 2024 · 6 comments
Labels
Bounties bug Something isn't working Posted
Milestone

Comments

@ecurrencyhodler
Copy link
Contributor

ecurrencyhodler commented Feb 29, 2024

Describe the bug
When scrolling L/R on the secondbrain organization bounties, the wrong bounty is displayed as it is not the next listed bounty on the org homepage. Here is the org: https://community.sphinx.chat/org/bounties/ck9drb84nncjnaefo090

Also when you click L, a deleted bounty page appears occasionally

LR.bug.mov

The bounty deleted page also appears on the home page:

Bounty.deleted.mov

Expected behavior

  • The bounty delete page should never appear. If there is no bounty, then no action should occur. Also the arrow to click the next button should be hidden.
  • The L/R button should display the next bounty as seen on the org homepage.

Desktop (please complete the following information):

  • Browser: Chrome

Acceptance Criteria

  • I have tested on Chrome desktop
  • I have posted a screenshot or video in my PR
  • I have created a test that the L/R button disappears if there are no more bounties to go to on the org homepage and home page
  • I have created a test that asserts a bounty deleted page never gets displayed
  • I have created a L/R test to display the correct bounty
  • I have rebased and tested locally before submitting my PR
  • I can submit a PR within 2 days of taking the bounty

Here is an example unit test
Here is an example component test

@ecurrencyhodler ecurrencyhodler added bug Something isn't working Bounties labels Feb 29, 2024
@ecurrencyhodler ecurrencyhodler moved this from 🆕 New to 🧨 To Do in Bounties Platform Feb 29, 2024
@ecurrencyhodler ecurrencyhodler added this to the Feb '24 milestone Feb 29, 2024
@aliraza556
Copy link
Contributor

Hi @ecurrencyhodler
Assign me?

@Vayras
Copy link
Contributor

Vayras commented Feb 29, 2024

@ecurrencyhodler can you assign this one to me

@Vayras
Copy link
Contributor

Vayras commented Mar 4, 2024

@ecurrencyhodler Since the next bounty (if present) will only be acknowledged after user has clicked on the button it is best to show an alert that user has reached the end of list, instead of disabling the button to scroll. what are your thoughts on this?
Screenshot 2024-03-04 at 6 55 43 PM

@Vayras
Copy link
Contributor

Vayras commented Mar 4, 2024

for now I have added the default html alert, we can implement a new site wide alert component, or use one from a library, which I think can be handled in a seprate PR from this.

@ecurrencyhodler
Copy link
Contributor Author

@Vayras We have a toast that appears on the bottom right. Can we use that instead? Message should be: There are no more bounties to display!

@Vayras
Copy link
Contributor

Vayras commented Mar 4, 2024

@Vayras We have a toast that appears on the bottom right. Can we use that instead? Message should be: There are no more bounties to display!

Sure let's use that

@Vayras Vayras removed their assignment Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounties bug Something isn't working Posted
Projects
Status: 🧨 To Do
Development

No branches or pull requests

3 participants