Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable lsat #48

Open
tobi-bams opened this issue Oct 19, 2022 · 5 comments
Open

Reusable lsat #48

tobi-bams opened this issue Oct 19, 2022 · 5 comments

Comments

@tobi-bams
Copy link
Contributor

tobi-bams commented Oct 19, 2022

List of changes that need to occur to achieve this

sphinx-relay

  • create an endpoint to get active lsat
  • make an update to the existing updateLsat endpoint to accommodate update of lsat when expired.
  • add a new column to the lsat table called status, to keep track of lsat status
    All these have been implemented, here is the PR [https://github.com/Feat/get update lsat sphinx-relay#439]

sphinx-bridge

  • create a getActiveLsat method to get active lsat from sphinx-relay
  • create the updateLsat method to update lsat in sphinx-relay
    This has been merged to sphinx-bridge already, here is the PR: [https://github.com/Feat/get update lsat kevkevinpal/sphinx-bridge#2]

sphinx-mac

  • create a method that handles the getLsat method passed from sphinx-bridge
  • create a method that handles the updateLsat method passed from sphinx-bridge
    This has been implemented, here is the PR [https://github.com/Feat/get update lsat kevkevinpal/sphinx-mac#2]

sphinx-nav-fiber

@kevkevinpal

@kevkevinpal
Copy link
Contributor

Looked over the relay changes and they look good

Opened a new PR to the stakwork/sphinx-bridge with the changes you made here

stakwork/sphinx-bridge#4

@kevkevinpal
Copy link
Contributor

also I think you forgot this change

jarvis-boltwall

https://github.com/stakwork/jarvis-boltwall/pull/1/files

@tobi-bams
Copy link
Contributor Author

also I think you forgot this change

jarvis-boltwall

https://github.com/stakwork/jarvis-boltwall/pull/1/files

Ops!!!......

That's true, thanks....

@kevkevinpal
Copy link
Contributor

Users can still use older relay version and not have the reusable lsats feature but if a user is on the older sphinx-mac version the browser will crash if they try and use getLsat and updateLsat

Also the older relay users wont have the status column so when they do upgrade all those lsats will be marked expired

@kevkevinpal
Copy link
Contributor

Merged sphinx-relay and sphinx-bridge

waiting on sphinx-mac to be merged and released before merging the sphinx-nav-fiber changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants