-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional text input for link posts #558
Conversation
prisma/migrations/20231011205259_free_link_comment/migration.sql
Outdated
Show resolved
Hide resolved
prisma/migrations/20231011205259_free_link_comment/migration.sql
Outdated
Show resolved
Hide resolved
prisma/migrations/20231011205259_free_link_comment/migration.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at these changes, I realized that it should be a lot easier to just also set text
and not only url
of the item instead of creating a comment as a separate item. This has the following advantages:
- can reuse existing
create_item
postgres function, so no db migration with support fornoCosts
needed - fee escalation can work as before: no need to mention something like
free, but compounds any future spam penalty
which not every user might understand - it just works™ without any backend changes 🎉 (did not test if it really requires zero backend changes but i have good faith belief in that)
- consistent edit UX: you can edit everything you were able to create in the same form
Another thing is that it doesn't "smell good" to add noCosts
as an exception to create_item
(which was meant to be a generic function) for a single use case.
It also might be better UX if the provided summary actually shows up at the top for every user instead of as a separate comment which might get lost if there are many comments? Using item.text
kind of works like a pinned comment in that case (except it's just regular UX like for discussion posts)
Thanks for putting in the work! It wasn't clear to me before that creating a separate comment might lead to all of this.
Thinking more about this, I wondered if it would break some assumptions in our code if link posts now suddenly also can have However, searching for |
I agree that this would ideally not require special treatment and simply occupy the |
Great idea to simplify with the text field... I will pursue that! |
I think this is ready now. |
02f50f1
to
49b57af
Compare
To resolve #504.